xfs
[Top] [All Lists]

RE: LBD patch and XFS problem!

To: "'Eric Sandeen'" <sandeen@xxxxxxx>, Gustavo Rincon <grincon@xxxxxxxxxxx>
Subject: RE: LBD patch and XFS problem!
From: Gustavo Rincon <grincon@xxxxxxxxxxx>
Date: Tue, 16 Dec 2003 08:28:15 -0600
Cc: "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>, Tony Lambert <tlambert@xxxxxxxxxxx>, Ben McMillan <ben@xxxxxxxxxxx>, "'Stefan Smietanowski'" <stesmi@xxxxxxxxxx>
Sender: linux-xfs-bounce@xxxxxxxxxxx
Hi, I did the HAVE_SECTOR_T definition in all the xfs Makefiles and the test
failed in the same
way that before.  Here is some information gotten from kdb (Look into the
attachment)


All the help that you can get me it is highly appreciated.

Thank you
Gustavo Rincon

-----Original Message-----
From: Eric Sandeen [mailto:sandeen@xxxxxxx]
Sent: Monday, December 15, 2003 5:06 PM
To: Gustavo Rincon
Cc: 'linux-xfs@xxxxxxxxxxx'; Tony Lambert; Ben McMillan
Subject: Re: LBD patch and XFS problem!


On Mon, 2003-12-15 at 14:46, Gustavo Rincon wrote:
> Hi, I need some help with XFS and LBD patch.

Whoohoo, we've just been discussing this... :)

> I was doing some testing with the linux-2.4.24-pre1+xfs + LBD patch
(gotten
> from <http://www.gelato.unsw.edu.au/patches/lbd/>) 

Which LBD patch did you use?  There is no 2.4.24-pre1 LBD patch.

There may already be some problems there, the LBD patch used to make
itself known via HAVE_SECTOR_T, but that's not there anymore.  So now
the conditional code in XFS for LBD doesn't work, and xfs has no way to
know that LBD is present.  Check your LBD patch for a definition of
HAVE_SECTOR_T....

We're probably going to remove all the LBD bits from 2.4 xfs, and push
the changes into Peter's patch, since xfs is now in 2.4.24 - I'll try to
get an updated patch to him soon.

In the meantime, you can probably fix things up by looking for
#ifdef HAVE_SECTOR_T
conditionals in XFS, and making them always true (either by removing the
tests, or defining it yourself in, say, xfs_linux.h)

That's just off the top of my head, no promises.

Until that's fixed, I'm not inclined to dig through all the stacks
posted below.  :)

-Eric

-- 
Eric Sandeen      [C]XFS for Linux   http://oss.sgi.com/projects/xfs
sandeen@xxxxxxx   SGI, Inc.          651-683-3102


Attachment: sgi2
Description: Binary data

<Prev in Thread] Current Thread [Next in Thread>