xfs
[Top] [All Lists]

Re: [RFC PATCH 1/3] Implement generic freeze feature

To: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
Subject: Re: [RFC PATCH 1/3] Implement generic freeze feature
From: "Takashi Sato" <t-sato@xxxxxxxxxxxxx>
Date: Wed, 30 Apr 2008 10:10:13 +0900
Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <linux-fsdevel@xxxxxxxxxxxxxxx>, <dm-devel@xxxxxxxxxx>, <xfs@xxxxxxxxxxx>, <linux-ext4@xxxxxxxxxxxxxxx>
In-reply-to: <20080428130358.GB2798@infradead.org>
References: <20080428193123t-sato@mail.jp.nec.com> <20080428103719.GA16030@infradead.org> <2E042A67F72447F6AAA0CC0605DBFA84@nsl.ad.nec.co.jp> <20080428130358.GB2798@infradead.org>
Sender: xfs-bounce@xxxxxxxxxxx
Hi,

bd_mount_sem can protect against only freezes and cannot protect against
unfreezes.  If multiple unfreezes run in parallel,  the multiple up() for
bd_mount_sem might occur incorrectly.

Indeed. The bit flag would fix that because unfreeze could then check for the bit beeing set first. So that's probably the easiest way to go.

I think the bit flag is more efficient than the semaphore. So I will consider whether it can be used for the freeze feature.

Cheers, Takashi


<Prev in Thread] Current Thread [Next in Thread>