xfs
[Top] [All Lists]

Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io

To: Jeff Moyer <jmoyer@xxxxxxxxxx>
Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io
From: Dan Williams <dan.j.williams@xxxxxxxxx>
Date: Fri, 15 Apr 2016 11:56:20 -0700
Cc: "Verma, Vishal L" <vishal.l.verma@xxxxxxxxx>, "hch@xxxxxxxxxxxxx" <hch@xxxxxxxxxxxxx>, "jack@xxxxxxx" <jack@xxxxxxx>, "axboe@xxxxxx" <axboe@xxxxxx>, "linux-nvdimm@xxxxxxxxxxx" <linux-nvdimm@xxxxxxxxxxx>, "david@xxxxxxxxxxxxx" <david@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>, "linux-block@xxxxxxxxxxxxxxx" <linux-block@xxxxxxxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "viro@xxxxxxxxxxxxxxxxxx" <viro@xxxxxxxxxxxxxxxxxx>, "linux-fsdevel@xxxxxxxxxxxxxxx" <linux-fsdevel@xxxxxxxxxxxxxxx>, "akpm@xxxxxxxxxxxxxxxxxxxx" <akpm@xxxxxxxxxxxxxxxxxxxx>, "linux-ext4@xxxxxxxxxxxxxxx" <linux-ext4@xxxxxxxxxxxxxxx>, "Wilcox, Matthew R" <matthew.r.wilcox@xxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=4UXOIgA15Dj0iBrT12T49T+xq0keZCAEg+1NEQH5DDc=; b=GjuRFuo5R+VFCO7s2W082B4nO84umWuM5utywYVGK1xsh4n4AKKJRWM5Om2Zoa5Oas 3kZY22POpxolwTHtDC5pUGDGfj8HzyZl9kdyPExjaiAHBpEJGo1KqWCywQvThixpRPH3 zWG0orP1AjnXXD5rOVobGsYYcxwOgHvmjaqvynAY/3nhqJBzhBcH3o4iAckPKjYS/RwZ A7qyvIDHvVkLRm8vtZl3QhsDL7glJR2qdSnboaL9ZdptRXV91KQOPokqlFU3l5Ya+DTl TEDX93icGFuG2mdJP3hZb8Gw21986VYx83BKZBkk7N07oc06DvAddIq7r5rLRb52jYSr xIYA==
In-reply-to: <x494mb2ivcl.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <1459303190-20072-1-git-send-email-vishal.l.verma@xxxxxxxxx> <1459303190-20072-6-git-send-email-vishal.l.verma@xxxxxxxxx> <x49twj26edj.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1460739288.3012.3.camel@xxxxxxxxx> <x49potq6bm2.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1460741821.3012.11.camel@xxxxxxxxx> <CAPcyv4hemNM4uQYCPBXyH+DWTOLvyBNBeMYstKbPdad_Cw48HQ@xxxxxxxxxxxxxx> <x49lh4e6928.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <CAPcyv4hRQj2ZsFj7Xa_=OwcHrzP9_5yUpt3LQ+bPH4PcLe7UCQ@xxxxxxxxxxxxxx> <x494mb2ivcl.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
On Fri, Apr 15, 2016 at 11:24 AM, Jeff Moyer <jmoyer@xxxxxxxxxx> wrote:
>> Moreover, we're going to do the full badblocks lookup anyway when we
>> call ->direct_access().  If we had that information earlier we can
>> avoid this fallback dance.
>
> None of the proposed approaches looks clean to me.  I'll go along with
> whatever you guys think is best.  I am in favor of wrapping up all that
> duplicated code, though.

Christoph originally pushed for open coding this fallback decision
per-filesystem.  I agree with you on the "none the above" options are
clean.

<Prev in Thread] Current Thread [Next in Thread>