Re: [PATCH] xfstests: unify apostrophes in output files

[Ilya Dryomov <idryomov@xxxxxxxxx>]

On Thu, Sep 19, 2013 at 7:20 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> xfstests: unify apostrophes in output files
>
> From: Tomas Racek <tracek@xxxxxxxxxx>
>
> With coreutils v8.16 the style of apostrophes changed from `word' to
> 'word'. This is breaking some tests which use the older form.
>
> This commit introduces function changes the golden output of the
> affected tests and introduces a filter for the older style output.
>
> [dchinner: modified to use a global filter in check rather than
> per-test filters]
>
> Signed-off-by: Tomas Racek <tracek@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
>
> (Resending as proper top-level, modified, reviewed patch --Eric)
>
>  check                 |  4 ++++
>  common/config         |  1 +
>  tests/generic/193.out | 16 ++++++++--------
>  tests/generic/230.out |  8 ++++----
>  tests/generic/235.out |  2 +-
>  tests/generic/245.out |  2 +-
>  tests/generic/294.out |  8 ++++----
>  tests/generic/306.out |  2 +-
>  tests/xfs/103.out     |  2 +-
>  tests/xfs/200.out     |  2 +-
>  10 files changed, 26 insertions(+), 21 deletions(-)
>
> diff --git a/check b/check
> index 4085eae..ba7fd21 100755
> --- a/check
> +++ b/check
> @@ -478,6 +478,10 @@ do
>                 echo " - no qualified output"
>                 err=true
>             else
> +
> +               # coreutils 2.16+ changed quote formats in error messages from

Should that be 8.16+?

Thanks,

                Ilya