Re: [PATCH 2/2] xfs_spaceman: Accounting for AGFL blocks

[Dhruvesh Rathore <adrscube@xxxxxxxxx>]

On Thu, Jan 29, 2015 at 9:18 AM, Dhruvesh Rathore <adrscube@xxxxxxxxx> wrote:
> On Thu, Jan 29, 2015 at 2:29 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>> On Wed, Jan 28, 2015 at 06:35:22PM +0530, ADRS PICT wrote:
>>> On Wed, Jan 28, 2015 at 7:27 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>>> > Hmmm - I think something is still missing - what are the sagbno and
>>> > eagbno parameters supposed to do?
>>>
>>> Actually the parameters sagbno and eagbno are not needed in this
>>> function and can be excluded.
>>
>> Why? Don't we still have to check the blocks found on the AGFL fll
>> within the range requested by the user, like we do for every extent
>> found in the btree?
>
> We had felt that the range check is not needed as we are fetching block 
> numbers
> from the allocation group free block array by the function
> xfs_alloc_read_agfl().
> And in xfs_alloc_read_agfl(), the error checking is done implicitly.
>
> However, after you have raised this point, it is clear to us that performing a
> range check will be a good way to catch and display a warning if the blocks 
> are
> out of range.
>

We have assimilated the changes you pointed out and have sent the
updated patches
in a new thread.

Regards,
A-DRS