Re: [PATCH] xfs: Check error during inode btree iteration in xfs_bulkstat()

[jie liu <jeff.u.liu@xxxxxxxxx>]

Looks good to me. Reviewed-by: Jie Liu <jeff.u.liu@xxxxxxxxx>

Cheers,

-Jeff

On Tue, Oct 21, 2014 at 10:31 PM, Jan Kara <jack@xxxxxxx> wrote:

xfs_bulkstat() doesn't check error return from xfs_btree_increment(). In
case of specific fs corruption that could result in xfs_bulkstat()
entering an infinite loop because we would be looping over the same
chunk over and over again. Fix the problem by checking the return value
and terminating the loop properly.

Coverity-id: 1231338
Signed-off-by: Jan Kara <jack@xxxxxxx>
---
Âfs/xfs/xfs_itable.c | 4 ++++
Â1 file changed, 4 insertions(+)

diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index f1deb961a296..66d5c619517d 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -474,6 +474,10 @@ xfs_bulkstat(
            Â*/
            agino = r.ir_startino + XFS_INODES_PER_CHUNK;
            error = xfs_btree_increment(cur, 0, &tmp);
+Â Â Â Â Â Â Â Â Â Â Â Âif (error) {
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âend_of_ag = 1;
+Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âbreak;
+Â Â Â Â Â Â Â Â Â Â Â Â}
            cond_resched();
        }
        /*
--
1.8.1.4

_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs