xfs
[Top] [All Lists]

Re: [PATCH v18 00/22] Richacls (Core and Ext4)

To: Jeremy Allison <jra@xxxxxxxxx>
Subject: Re: [PATCH v18 00/22] Richacls (Core and Ext4)
From: Andreas Gruenbacher <agruenba@xxxxxxxxxx>
Date: Mon, 14 Mar 2016 00:02:13 +0100
Cc: Steve French <smfrench@xxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Linux NFS Mailing List <linux-nfs@xxxxxxxxxxxxxxx>, "Theodore Ts'o" <tytso@xxxxxxx>, "linux-cifs@xxxxxxxxxxxxxxx" <linux-cifs@xxxxxxxxxxxxxxx>, Linux API <linux-api@xxxxxxxxxxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, XFS Developers <xfs@xxxxxxxxxxx>, Andreas Dilger <adilger.kernel@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, linux-ext4 <linux-ext4@xxxxxxxxxxxxxxx>, Anna Schumaker <anna.schumaker@xxxxxxxxxx>
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <20160311230254.GG2792@jra3>
References: <1456733847-17982-1-git-send-email-agruenba@xxxxxxxxxx> <20160311140134.GA14808@xxxxxxxxxxxxx> <CAHc6FU4t3yisCM=MXrHRmCja_A8eZOpVa1smJ0gUhv+vuUAuXA@xxxxxxxxxxxxxx> <CAH2r5mv3OTmPOQBV7xc-uZmB0gWxykXOCEVOcybx3tbHiViTZg@xxxxxxxxxxxxxx> <20160311230254.GG2792@jra3>
On Sat, Mar 12, 2016 at 12:02 AM, Jeremy Allison <jra@xxxxxxxxx> wrote:
> On Fri, Mar 11, 2016 at 02:05:16PM -0600, Steve French wrote:
>> Sounds like I need to quickly rework the SMB3 ACL helper functions
>> for cifs.ko
>>
>> Also do you know where is the current version of the corresponding
>> vfs_richacl for
>> Samba which works with the current RichACL format?
>
> I have a patch for a new vfs_richacl somewhere. I remember
> sending it to Andreas for testing...

Ah, the patch was for testing, not resting ... how could I get that mixed up.

I've applied your patch to the latest master branch, made it compile
again, and fixed a few obvious problems. The results I get with
smbcacls look reasonable now.

The code is here:
  https://github.com/andreas-gruenbacher/samba richacl

I've used the following smb.conf:
  [richacl]
  comment = Richacl directory
  path = /mnt/ext4
  vfs objects = richacl
  writeable = yes
  browseable = yes

Is there a particular reason why you didn't make vfs_richacl a
dynamically loadable module?

Thanks,
Andreas

<Prev in Thread] Current Thread [Next in Thread>