Re: [PATCH] xfsprogs: fix cut & paste error in xfs_fsr.c

[Jan Tulak <jtulak@xxxxxxxxxx>]

On Tue, Nov 10, 2015 at 9:35 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:

> On Tue, Nov 10, 2015 at 12:21:10PM -0600, Eric Sandeen wrote:
>> Commit:
>>
>> 7141fc xfsprogs: make fsr use mntinfo when there is no mntent
>>
>> added an inadvertent "break;" to initallfs() after the call
>> to find_mountpoint_check(); this is likely a cut & paste error
>> from the call in find_mountpoint(), where we really *do* want to
>> stop after the first one we find.
>>
>> Fix that by removing the break, and fix the declaration-after-code.
>
> That's not the right fix - the find_mountpoint_check() shoul dnot be
> there at all. Patch to clean it all up is below.
>
> -Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
>
> fsr: clean up mountpoint checks
>
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> Fix up a stray hunk of code from commit 7141fc5 ("xfsprogs: make fsr
> use mntinfo when there is no mntent") that coverity reported. Also
> clean up a couple of whitespace issues introduced with that commit,
> too.

Um, ok, well it wasn't your misapplication, it was there in the original patch,
and I wasn't sure of Jan's intent, having gone so far as to add local vars
to support that placement. ;)

This seems fine, I guess I'll send another patch to make *ms local to
find_mountpoint_check(), and rename some vars ("sb" and "mp" have their
own expected meanings in xfsprogs)

âHmmm, sorry about the mess... :-( I will look on the patch again too.

Speaking about ÂCoverity, is there a way I can get to it and use it myself? (Maybe it may be bâetter to continue this off list - from what I heard, Coverity guys don't like to be talk about publicly...)

Cheers,

Jan

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx