Re: [PATCH 08/11] xfsprogs: Add a timer implementation for OS X

[Jan Tulak <jtulak@xxxxxxxxxx>]

On Mon, Aug 31, 2015 at 9:00 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

On Wed, Aug 26, 2015 at 02:02:32PM +0200, Jan Tulak wrote:
> OS X does not have the timer used in xfs_repair.
> Add a simple implementation providing the required
> capabilities.

This doesn't look like it would actually work.

âAs I understand the timer usage, it should periodically send a signal. The timer code I posted really does this, at least when I take theÂtimer_* functions "as it is" outside and test them, calling them in the same order as in the repair code. I tested that before sending the patch.

I have to try it in xfs_repair yet - this is limited by having small storage space for a filesystem, where the reporting interval would be noticeable. The best thing for this I have now is an old USB2 8 GB flash drive, filled with multiple copies of installed Debian. However, even on a raspberry pi, it still runs quickly. I guess few hundreds of GB would do it, but I need to dig out an old USB2-sata reduction somewhere and a HDD... (And I didn't noticed any difference in output.)

So in meantime, why do you think this won't work?

Cheers,

Jan

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx