xfs
[Top] [All Lists]

Re: [PATCH v3] xfsprogs: blkid is now mandatory

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH v3] xfsprogs: blkid is now mandatory
From: Jan Tulak <jtulak@xxxxxxxxxx>
Date: Tue, 11 Aug 2015 18:40:39 +0200
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1490980415.3591793.1438866795648.JavaMail.zimbra@xxxxxxxxxx>
References: <1156743222.24471614.1436281858017.JavaMail.zimbra@xxxxxxxxxx> <1436346893-11831-1-git-send-email-jtulak@xxxxxxxxxx> <1508777144.956841.1437482376774.JavaMail.zimbra@xxxxxxxxxx> <20150726162530.GE29329@xxxxxxxxxxxxx> <1326157887.2004059.1438598404429.JavaMail.zimbra@xxxxxxxxxx> <55BFA2C5.20408@xxxxxxxxxx> <1050814645.2742881.1438702230663.JavaMail.zimbra@xxxxxxxxxx> <55C0E73B.1000904@xxxxxxxxxxx> <1490980415.3591793.1438866795648.JavaMail.zimbra@xxxxxxxxxx>
On Thu, Aug 6, 2015 at 3:13 PM, Jan Tulak <jtulak@xxxxxxxxxx> wrote:
>
> It looks like it works. Though I need to do some testing before I send the patch.
> Unfortunately, making FS tests without the ability to mount it on the machine
> requires USB drive shuffling and it is hard to automate it... :-)
>
(Sorry for spam, Eric, resubmitting it with mailing list in cc)

My hope was premature. After long searching for "why there is not created any FS,"
I found that using mkfs on OS X on block devices probably wasn't ever enabled.
Some platform_ functions in libxfs/darwin.h used for block device work are empty
(so it just silently fails).

I edited the doc/INSTALL respectively and once I check and clean the patches,
I submit the updates in the compatibility patchset with block devices disabled.

Cheers,
Jan

--
<Prev in Thread] Current Thread [Next in Thread>