Re: [PATCH 02/11] xfsprogs: avoid dependency on linux XATTR_SIZE/LIST_MAX

[Jan Tulak <jtulak@xxxxxxxxxx>]

On Mon, Aug 31, 2015 at 8:58 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> index b1c0c10..d532f44 100644
> --- a/libhandle/handle.c
> +++ b/libhandle/handle.c
> @@ -21,6 +21,8 @@
>Â #include "xfs.h"
>Â #include "handle.h"
>Â #include "parent.h"
> +#include "xfs/xfs_arch.h"
> +#include "xfs/xfs_format.h"

These headers should not be used in libhandle. As mentioned last time I
think libhandle should get it's own LIBHANDLE_XATTR_LIST_MAX define,
separate frome the one for the on disk format.

âWell, you wrote about adding it into xfs_format.h. I don't recall (and can't find) anything else regarding XATTR_SIZE...Â

> Eww, looks like we depend on these Linux values in the on disk
> defintion. I think we need to add new XFS_XATTR_SIZE_MAX and
> XFS_XATTR_LIST_MAX defintions to xfs_format.h and use them where

> we currently use these.

So â

Â

âthe XFS_ defines in xfs_formatâ.h should be there, I just need to add another LIBHANDLE_ variant so we don't include the headers, right?

âCheers,

Janâ

--

Jan Tulak

jtulak@xxxxxxxxxxÂ/ jan@xxxxxxxx