| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK |
| From: | Ming Lei <ming.lei@xxxxxxxxxxxxx> |
| Date: | Fri, 1 Apr 2016 08:31:06 +0800 |
| Cc: | linux-block@xxxxxxxxxxxxxxx, Boaz Harrosh <boaz@xxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxx>, Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Anton Altaparmakov <anton@xxxxxxxxxx>, drbd-dev@xxxxxxxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160331075228.GA2491@xxxxxxxxxxxxx> |
| References: | <1459354637-17415-1-git-send-email-ming.lei@xxxxxxxxxxxxx> <1459354637-17415-3-git-send-email-ming.lei@xxxxxxxxxxxxx> <20160330171927.GA13320@xxxxxxxxxxxxx> <CACVXFVNtphY8bWrdMKcR7jYn5hD=H5H6jXrY111K0kZ8jJQHWw@xxxxxxxxxxxxxx> <20160331075228.GA2491@xxxxxxxxxxxxx> |
On Thu, Mar 31, 2016 at 3:52 PM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Thu, Mar 31, 2016 at 09:02:59AM +0800, Ming Lei wrote: >> That way may cause trouble to blk_type.h because it needs bvec_iter, >> then looks not good to always include bvec_iter.h into blk_type.h. > > I'd expect bvec.h to be always included in blk_types.h, and replace That should be fine, but blk_types.h will become more fat. > the inclusion of blk_types.h in fs.h eventually. I guess it can't be done because fs.h need 'struct bio'. thanks, Ming |
| Previous by Date: | XFS reverse-mapping, reflink, and scrub update, Darrick J. Wong |
|---|---|
| Next by Date: | K9- car wirelss professional karaoke player with blueooth function, thomas@xxxxxxxxxxxxx |
| Previous by Thread: | Re: [PATCH v1 2/8] block: make 'struct bvec_iter' not depend on CONFIG_BLOCK, Christoph Hellwig |
| Next by Thread: | [PATCH v1 3/8] block: mark 1st parameter of bvec_iter_advance as const, Ming Lei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |