Re: [PATCH 1/2] xfsprogs: replace deprecated ustat call with statfs in libxfs/linux.c

[Kamal Dasu <kdasu.kdev@xxxxxxxxx>]

Christoph,

> More seriously - ustat provides the benefit to check if the block device
> is mounted anywhere, which we make use of here.  A statfs of the block
> device path doesn't provide that functionality at all.
>

Now I understand your concern. However if we would want to replace the
deprecated ustat call, then what other way would be acceptable to
achieve the same. Would parsing the /proc/mounts for the block device
name suffice ?.

Thanks
Kamal

On Fri, Mar 2, 2012 at 2:45 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Mar 01, 2012 at 04:11:24PM -0500, Kamal Dasu wrote:
>> >From the ustat man page
>>
>> NOTES
>>        ustat() is deprecated and has only  been  provided  for 
>>  compatibility.
>>        All new programs should use statfs(2) instead.
>
> xfsprogs isn't new :)
>
> More seriously - ustat provides the benefit to check if the block device
> is mounted anywhere, which we make use of here.  A statfs of the block
> device path doesn't provide that functionality at all.
>