Bug#695640: xfs_quota: cannot find mount point for path: Success

[Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>]

Oops. Just realized I still hadn't responded. Sorry.

On 20 March 2013 22:09, Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> > # xfs_quota Â-x -c "quota -N -u brian"

>
> This prints the quota information 20 times. Huh?

How many mount points do you have? 20?

No. More actually. Today I get

hq ~ # cat /proc/mounts Â| wc --lines

34

hq ~ # xfs_quota Â-x -c "quota -N -u brian" | wc --lines

44

hq ~ # xfs_quota Â-x -c "quota -N -u brian" /home /share | wc --lines

4

Â

The command has once for each of the mount points, and the command

itself iterates mount points because you haven't given it a mount
point to look at. So, double iteration. ÂThis same problem was fixed
for the report command by setting it to be a global command i.e. the
fix I mentioned previously that you tested should prevent this
second case, and maybe even the first.

As far as I can tell this happens with the patched xfs_quota.

hq /home/brian/xfsprogs # git diff

diff --git a/quota/quot.c b/quota/quot.c

index a7782b4..6cb665d 100644

--- a/quota/quot.c

+++ b/quota/quot.c

@@ -418,6 +418,7 @@ quot_init(void)

    quot_cmd.args = _("[-bir] [-gpu] [-acv] [-f file]");

    quot_cmd. filesystem ownership");

    quot_cmd.help = quot_help;

+ Â Â Â quot_cmd.flags = CMD_FLAG_GLOBAL;

Â

    if (expert)

        add_command(&quot_cmd);

As this version is based on git, I just did a git pull:

hq /home/brian/xfsprogs # git pull

Updating b326e06..64ae7fc

Fast-forward

Âmkfs/xfs_mkfs.c | Â 18 ++++++++++++++++++

Â1 files changed, 18 insertions(+), 0 deletions(-)

Doesn't look related to this, don't think I need to retest.

--
Brian May <brian@xxxxxxxxxxxxxxxxxxxxxxxx>