Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to

To:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe()
From:	Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date:	Fri, 23 Sep 2016 13:36:12 -0700
Cc:	Dave Chinner <david@xxxxxxxxxxxxx>, CAI Qian <caiqian@xxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=KFY0rMW1HJ8TQ6LiaEJvP3L4mIBdEBXkcrHgG0u82lg=; b=HVlIuDLzbpLzEpg8CbBWx3dv3oWsg6s/aAwCj9LDhW8nTaN4mdoX2CyITZ0OxbabwM UpmQyh7cAe8gwhZCvECyzc8HtYanZmU9iunoDVhX0cyypDA8V4KlzLe77W8Qls0xHBGi AflnktQQrDfcsmbmOoJLsI+2+7p1bqFZud2AXkpxI8/0nwUbuaxyanypvgCqiJhQIg8T L9SllPHG0ojJ26SdRxPjS3LA59hj71PBDmszb67XGBkIsB12L+xsjf+FfloatNxIdC6i Amt+8kuLbQkI0tyYQXMLFTayR1FmY4AtDX+tpK1zRUUdKKr8ugPzF/qi1zxL4RcGAdx9 N1cw==
In-reply-to:	<20160923201025.GJ2356@xxxxxxxxxxxxxxxxxx>
References:	<20160909221945.GQ2356@xxxxxxxxxxxxxxxxxx> <CA+55aFzTOOB6oEVaaGD0N7Uznk-W9+ULPwzsxS_L_oZqGVSeLA@xxxxxxxxxxxxxx> <20160914031648.GB2356@xxxxxxxxxxxxxxxxxx> <CA+55aFznQaOWoSMNphgGJJWZ=8-odrc0DAUMzfGPQe+_N4UgNA@xxxxxxxxxxxxxx> <20160914042559.GC2356@xxxxxxxxxxxxxxxxxx> <20160917082007.GA6489@xxxxxxxxxxxxxxxxxx> <20160917190023.GA8039@xxxxxxxxxxxxxxxxxx> <20160923190032.GA25771@xxxxxxxxxxxxxxxxxx> <20160923190326.GB2356@xxxxxxxxxxxxxxxxxx> <CA+55aFxzPH2AYvDVWSAomO6bN_sW4+qDv87Xbq8XHMyvBEYe+w@xxxxxxxxxxxxxx> <20160923201025.GJ2356@xxxxxxxxxxxxxxxxxx>
Sender:	linus971@xxxxxxxxx

On Fri, Sep 23, 2016 at 1:10 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> OTOH, considering the quality of documentation, I'm somewhat tempted to go
> for "sleep only if it had been completely full when we entered; once there's
> some space feed as much as fits and be done with that".  OTTH, I'm not sure
> that no userland cr^Hode will manage to be hurt by that variant...

Let's just try it.

If that then doesn't work, we can introduce your odd code (with a
*big* comment). Ok?

               Linus

<Prev in Thread]	Current Thread	[Next in Thread>
Re: xfs_file_splice_read: possible circular locking dependency detected, (continued) Re: xfs_file_splice_read: possible circular locking dependency detected, Al Viro Re: xfs_file_splice_read: possible circular locking dependency detected, Al Viro Re: xfs_file_splice_read: possible circular locking dependency detected, Linus Torvalds [RFC][CFT] splice_read reworked, Al Viro [PATCH 01/11] fix memory leaks in tracing_buffers_splice_read(), Al Viro [PATCH 02/11] splice_to_pipe(): don't open-code wakeup_pipe_readers(), Al Viro [PATCH 03/11] splice: switch get_iovec_page_array() to iov_iter, Al Viro [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds <= Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Nicholas Piggin Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Chuck Lever [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Miklos Szeredi Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro [PATCH 06/12] new helper: add_to_pipe(), Al Viro Re: [PATCH 06/12] new helper: add_to_pipe(), Miklos Szeredi [PATCH 10/12] new iov_iter flavour: pipe-backed, Al Viro

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:	Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro
Next by Date:	Re: [PATCH] xfs: quiesce the filesystem after recovery on readonly mount, Dave Chinner
Previous by Thread:	Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro
Next by Thread:	Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro

Next by Date:

Re: [PATCH] xfs: quiesce the filesystem after recovery on readonly mount, Dave Chinner

Previous by Thread:

Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro

Next by Thread:

Re: [PATCH 04/11] splice: lift pipe_lock out of splice_to_pipe(), Al Viro

Indexes:

[Date] [Thread] [Top] [All Lists]