Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to

To:	Andreas Schwab <schwab@xxxxxxxxxxxxxx>
Subject:	Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()
From:	Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date:	Wed, 21 Dec 2016 11:12:55 -0800
Cc:	Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, CAI Qian <caiqian@xxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=0skx/KUWZjKQknSeKmE3ylCCqy8L/TxN4ruy3GyeEgk=; b=U/BmcQ9yU+s5qMdHHot6Hg1smssTcena+0I3fC72DP6SSUjmbzM42zcgSIwhoSyGpl L/ybns18jAkc2yO9yV9DrTFTam/AenJuj/jzWXOWUaqL/rbHd5uwSaHhpzPM0Bkio+2V SWr+7h8SWGe7vuLwyYZTq6/ik7w0NFK/f24UnmN8DU4/4RMB2CQd5HcxYb+VGErWfV9S UGto7STpY+L4PsyOSMCxagifNEvxfHSY1x6OqdgUvLqkodn7O2CeIsXRB3+L1ERjdBFv GMn3uOvqxqXotHEFwn0HJlz95xJv5l/3/B2v+jY3rVz347zW5BKQ3Hp2+p4m/NOOyYUD p2jg==
In-reply-to:	<87shphaz78.fsf@xxxxxxxxxxxxxx>
References:	<20160917190023.GA8039@xxxxxxxxxxxxxxxxxx> <20160923190032.GA25771@xxxxxxxxxxxxxxxxxx> <20160923190326.GB2356@xxxxxxxxxxxxxxxxxx> <CA+55aFxzPH2AYvDVWSAomO6bN_sW4+qDv87Xbq8XHMyvBEYe+w@xxxxxxxxxxxxxx> <20160923201025.GJ2356@xxxxxxxxxxxxxxxxxx> <CA+55aFyr-X_6FcWkSXBUcxV0p1BUZw8d=46wawv2x+8y7f8YcQ@xxxxxxxxxxxxxx> <20160924035951.GN2356@xxxxxxxxxxxxxxxxxx> <87shpmxrey.fsf@xxxxxxxxxxxxxx> <CA+55aFyJGz6njFjKe8O0+XRJhCrPHA_wnEuLbGSGypJ0G2-vpQ@xxxxxxxxxxxxxx> <20161218201207.GY1555@xxxxxxxxxxxxxxxxxx> <20161218203003.GZ1555@xxxxxxxxxxxxxxxxxx> <CA+55aFzPE6FbwX2NuiMkz9G+FzAoiNeb8jOSWwSoX3O7+KuH4Q@xxxxxxxxxxxxxx> <87shphaz78.fsf@xxxxxxxxxxxxxx>
Sender:	linus971@xxxxxxxxx

On Wed, Dec 21, 2016 at 10:56 AM, Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
>
> FWIW, I have verified that the testsuite of pv succeeds with this patch:

Ok, thanks, committed.

Al, looking at this area, I think there's some room for cleanups. In
particular, isn't the loop in opipe_prep() now just
"wait_for_space()"? I'm also thinking that we could perhaps remove the
SIGPIPE/EPIPE handling from splice_to_pipe()..

Hmm?

               Linus

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), (continued) Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Andreas Schwab Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Al Viro Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Andreas Schwab Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Andreas Schwab Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Linus Torvalds <=

Previous by Date:	Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Andreas Schwab
Next by Date:	Super Adhesive clothes hook, kathy@xxxxxxxxxx
Previous by Thread:	Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe(), Andreas Schwab
Next by Thread:	[PATCH] xfs_io: implement 'utimes' command, Deepa Dinamani
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [PATCH 04/12] splice: lift pipe_lock out of splice_to_pipe()