xfs
[Top] [All Lists]

[PATCH] xfs: fix xfs_error_get_cfg for negative errnos

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs: fix xfs_error_get_cfg for negative errnos
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Fri, 8 Jul 2016 14:32:17 -0500
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
xfs_error_get_cfg() is called with bp->b_error as an arg,
which is negative, so the switch statement won't ever find
any matches.

This results in only the default error handler having
any effect, as EIO/ENOSPC/ENODEV get ignored due to the
wrong sign.

It seems simplest to always flip the error sign to positive,
so that we can handle either negative errors in bp->b_error,
or possibly a positive errno via something like
xfs_error_get_cfg(EIO) - this future-proofs the function.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---

I'm still chasing down some odd behaviors in the error handling
patches but this seems worth sending now :)

diff --git a/fs/xfs/xfs_sysfs.c b/fs/xfs/xfs_sysfs.c
index 4c2c550..79cfd3f 100644
--- a/fs/xfs/xfs_sysfs.c
+++ b/fs/xfs/xfs_sysfs.c
@@ -634,6 +634,9 @@ xfs_error_get_cfg(
 {
        struct xfs_error_cfg    *cfg;
 
+       if (error < 0)
+               error = -error;
+
        switch (error) {
        case EIO:
                cfg = &mp->m_error_cfg[error_class][XFS_ERR_EIO];

<Prev in Thread] Current Thread [Next in Thread>