Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was miss

xfs

Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was miss

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing
From:	Jan Tulak <jtulak@xxxxxxxxxx>
Date:	Wed, 5 Aug 2015 05:49:37 -0400 (EDT)
Cc:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150804230000.GW16638@dastard>
References:	<1438612789-17486-5-git-send-email-jtulak@xxxxxxxxxx> <1438680314-23950-1-git-send-email-jtulak@xxxxxxxxxx> <20150804111812.GD18906@xxxxxxxxxxxxx> <773923690.2696215.1438697980321.JavaMail.zimbra@xxxxxxxxxx> <20150804230000.GW16638@dastard>
Thread-index:	XykxJ9qwGGyQhKyAqiHaNrq3jt8uRg==
Thread-topic:	xfsprogs: Add ifdef dirent checks where it was missing


----- Original Message -----
> From: "Dave Chinner" <david@xxxxxxxxxxxxx>
> To: "Jan Tulak" <jtulak@xxxxxxxxxx>
> Cc: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
> Sent: Wednesday, August 5, 2015 1:00:00 AM
> Subject: Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was  
> missing
> 
> On Tue, Aug 04, 2015 at 10:19:40AM -0400, Jan Tulak wrote:
> > ----- Original Message -----
> > > From: "Christoph Hellwig" <hch@xxxxxxxxxxxxx>
> > > 
> > > Needs to be fixed to avoid > 80 char lines.
> > > 
> > 
> > I don't see any >80 char line in this patch. O_o
> > The longest line is 73 in the code and 62 in commit
> > message. Though... maybe it can be a tab width issue?
> > I use four spaces for a tab...
> 
> 8 spaces to a tab, please. Same coding style rules as for writing
> kernel code. ;)

All right, fixed patch sent. :-)

Cheers,
Jan

-- 
Jan Tulak
jtulak@xxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v3 03/11] xfsprogs: undefined variable fix, (continued) [PATCH v3 03/11] xfsprogs: undefined variable fix, Jan Tulak Re: [PATCH v3 03/11] xfsprogs: undefined variable fix, Christoph Hellwig [PATCH v2 01/11] xfsprogs: Don't Make .po files with gettext disabled, Jan Tulak [PATCH v3 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak Re: [PATCH v3 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Christoph Hellwig Re: [PATCH v3 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Christoph Hellwig Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Dave Chinner Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak <= [PATCH v5 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak [PATCH v3 05/11] xfsprogs: Change OS X-specific CFLAGS/LDFLAGS, Jan Tulak Re: [PATCH v3 05/11] xfsprogs: Change OS X-specific CFLAGS/LDFLAGS, Christoph Hellwig [PATCH v3 06/11] xfsprogs: Add includes required for OS X builds, Jan Tulak Re: [PATCH v3 06/11] xfsprogs: Add includes required for OS X builds, Christoph Hellwig [PATCH 06/11] xfsprogs: Add includes required for OS X builds, Jan Tulak [PATCH v3 07/11] xfsprogs: missing and dummy calls for OS X support, Jan Tulak [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Jan Tulak Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Christoph Hellwig Re: [PATCH v3 08/11] xfsprogs: Add fls check into autoconf, Jan Tulak

Previous by Date:	[PATCH v5 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak
Next by Date:	[PATCH 02/10] xfs: configurable error behaviour via sysfs, Dave Chinner
Previous by Thread:	Re: [PATCH v4 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Dave Chinner
Next by Thread:	[PATCH v5 04/11] xfsprogs: Add ifdef dirent checks where it was missing, Jan Tulak
Indexes:	[Date] [Thread] [Top] [All Lists]