xfs
[Top] [All Lists]

Re: Defrag in shrinkers

To: Christoph Lameter <cl@xxxxxxxxx>
Subject: Re: Defrag in shrinkers
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Fri, 14 May 2010 22:36:03 +0200
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Pekka Enberg <penberg@xxxxxxxxxxxxxx>, npiggin@xxxxxxx
In-reply-to: <alpine.DEB.2.00.1005141244380.9466@xxxxxxxxxxx> (Christoph Lameter's message of "Fri\, 14 May 2010 12\:46\:52 -0500 \(CDT\)")
References: <1273821863-29524-1-git-send-email-david@xxxxxxxxxxxxx> <alpine.DEB.2.00.1005141244380.9466@xxxxxxxxxxx>
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (gnu/linux)
Christoph Lameter <cl@xxxxxxxxx> writes:

> Would it also be possible to add some defragmentation logic when you
> revise the shrinkers? Here is a prototype patch that would allow you to
> determine the other objects sitting in the same page as a given object.
>
> With that I hope that you have enough information to determine if its
> worth to evict the other objects as well to reclaim the slab page.

I like the idea, it would be useful for the hwpoison code too,
when it tries to clean a page.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.

<Prev in Thread] Current Thread [Next in Thread>