Re: [PATCH 2/2] xfs: don't truncate prealloc from frequently accessed inodes

[Andi Kleen <andi@xxxxxxxxxxxxxx>]

Dave Chinner <david@xxxxxxxxxxxxx> writes:
>
> To avoid this problem, keep a count of the number of ->release calls
> made on an inode. For most cases, an inode is only going to be opened
> once for writing and then closed again during it's lifetime in
> cache. Hence if there are multiple ->release calls, there is a good
> chance that the inode is being accessed by the NFS server. Hence
> count up every time ->release is called while there are delalloc
> blocks still outstanding on the inode.

Seems like a hack. It would be cleaner and less fragile to add a
explicit VFS hint that is passed down from the nfs server, similar
to the existing open intents.

-Andi

-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.