xfs
[Top] [All Lists]

Re: [PATCH] XFS tuning on software RAID5 partitionable array; error in x

To: Hubert Verstraete <hubskml@xxxxxxx>
Subject: Re: [PATCH] XFS tuning on software RAID5 partitionable array; error in xfsprogs 2.9.8
From: Andi Kleen <andi@xxxxxxxxxxxxxx>
Date: Fri, 16 May 2008 13:30:15 +0200
Cc: xfs@xxxxxxxxxxx
In-reply-to: <482D6388.7040602@free.fr> (Hubert Verstraete's message of "Fri, 16 May 2008 12:35:52 +0200")
References: <47D90614.9040206@free.fr> <18408.36753.223347.129420@notabene.brown> <47E92EE2.1080108@free.fr> <20080326065232.GA21970@percy.comedia.it> <47EA71BF.8050800@tmr.com> <47EA8CF4.7080201@free.fr> <47EA99AD.9060400@free.fr> <482D6388.7040602@free.fr>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux)
Hubert Verstraete <hubskml@xxxxxxx> writes:
>
> The line 89 in libdisk/md.c is: "free(dfile2);" but it should have
> remained "if (dfile2) free(dfile2);" because dfile2 is null in case
> mkfs.xfs is run on an MD device.

ISO-C free() is defined to do nothing on a NULL input.

-Andi


<Prev in Thread] Current Thread [Next in Thread>