xfs
[Top] [All Lists]

Re: [XFS-1.0.2,LVM-1.0.1,linux-2.4.14] "mount -U <uuid>" does not work w

To: Steve Lord <lord@xxxxxxx>
Subject: Re: [XFS-1.0.2,LVM-1.0.1,linux-2.4.14] "mount -U <uuid>" does not work with XFS.
From: karlheg@xxxxxxxxxxxxxx (Karl M. Hegbloom)
Date: 10 Dec 2001 09:39:56 -0800
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <1007996560.27133.2.camel@jen.americas.sgi.com>
References: <871yi6zq3z.fsf@juniper.intra.microsharp.com> <1007996560.27133.2.camel@jen.americas.sgi.com>
Sender: owner-linux-xfs@xxxxxxxxxxx
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Artificial Intelligence)
>>>>> "Steve" == Steve Lord <lord@xxxxxxx> writes:

    Steve> On Fri, 2001-12-07 at 15:18, Karl M. Hegbloom wrote:
    >> [ I am not subscribed to the list; Please Cc. ]
    >> 
    >> I'm using "mount" version 2.11m-1 (debian "sid"), Linux 2.4.14 from
    >> Debian "kernel-source", version 2.4.14-1, patched with Debian
    >> supplied "kernel-patch-xfs", version 1.0.2-2, and LVM release 1.0.1
    >> patched in by myself from source obtained directly from the LVM
    >> site...

    Steve> Since the mount by uuid code is in the mount command, it is possible
    Steve> you do not have a recent enough mount command there. Check for XFS
    Steve> specific code in the mount source.

 I will look and see...  I would assume that since the man page
 mentions XFS explicitly wrt UUID= mounting, that it is a recent
 enough version.

% apt-get source mount
Reading Package Lists... Done
Building Dependency Tree... Done
Need to get 1487kB of source archives.
Get:1 http://http.us.debian.org unstable/main util-linux 2.11m-1 (dsc) [679B]
Get:2 http://http.us.debian.org unstable/main util-linux 2.11m-1 (tar) [1437kB]
Get:3 http://http.us.debian.org unstable/main util-linux 2.11m-1 (diff) 
[48.8kB]                                   
Fetched 1487kB in 10s (148kB/s)                                                 
                                   
dpkg-source: extracting util-linux in util-linux-2.11m

 <time passes while karlheg greps code ...>

mount/mount_by_label.c:
8<----------------------------------------------------------------->8
/* for now, only ext2, ext3 and xfs are supported */
static int
get_label_uuid(const char *device, char **label, char *uuid) {
8<----------------------------------------------------------------->8

 Well, it's _supposed_ to work...  But does not.

 They used a fake "xfs_sb" struct, with dummy's in it for padding to
 try and get the right offsets for the uuid_t and the sb_fname[].  I
 think they (mount) got the offset correct for the uuid_t, but it
 looks to me like the offset of the label can vary depending on if
 you've built XFS with debugging or not, since there are inline
 xfs_inode_t's in there.  It would be nice if the label was higher in
 the struct, in this case.

 Perhaps there should be ioctl's for obtaining the UUID and filesystem
 label, given a file descriptor open on the block device?

 Ok; it's a problem with LVM LV's and XFS; I just tested an XFS in a
 real x86 BIOS partition, and it worked fine with -U.

 Apparently the offset to the sb_fname is correct also; I tested a
 "mount -L" with the same partition, and it works fine.  (but not on
 an LVM LV.)

 I will report the bug against "util-linux", perhaps with a patch,
 since I'm now looking at the peice of code that is likely causing the
 problem.  (There's a big comment right there also.)

 Thank you.

-- 
mailto: (Karl M. Hegbloom) karlheg@xxxxxxxxxxxxxx
http://www.microsharp.com
phone://USA/WA/360-260-2066
jabber: karlheg@xxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>