| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] add more statics & drop some unused functions |
| From: | Felix Blyakher <felixb@xxxxxxx> |
| Date: | Wed, 1 Jul 2009 23:51:10 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx> |
| In-reply-to: | <4A48D218.5050208@xxxxxxxxxxx> |
| References: | <4A1C3D65.4020306@xxxxxxxxxxx> <20090527102319.GA28274@xxxxxxxxxxxxx> <4A48D218.5050208@xxxxxxxxxxx> |
On Jun 29, 2009, at 9:39 AM, Eric Sandeen wrote: Christoph Hellwig wrote:On Tue, May 26, 2009 at 02:05:09PM -0500, Eric Sandeen wrote:A lot more functions could be made static, but they need forward declarations; this does some easy ones, and also found a few unused functions in the process.Looks good to me.Felix, do you plan to merge this one? Eric, this patch doesn't apply cleanly now: Applying xfs: add more statics & drop some unused functions error: patch failed: fs/xfs/linux-2.6/xfs_sync.c:640 error: fs/xfs/linux-2.6/xfs_sync.c: patch does not apply error: patch failed: fs/xfs/linux-2.6/xfs_sync.h:51 error: fs/xfs/linux-2.6/xfs_sync.h: patch does not apply Patch failed at 0002. Can you rebase and repost it? Thanks, Felix |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH V3] xfs_repair: fix agcount*agblocks overflows, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] add more statics & drop some unused functions, Eric Sandeen |
| Previous by Thread: | Re: [PATCH] add more statics & drop some unused functions, Felix Blyakher |
| Next by Thread: | Re: [PATCH] add more statics & drop some unused functions, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |