| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer |
| From: | Alex Elder <aelder@xxxxxxx> |
| Date: | Thu, 10 Nov 2011 14:35:13 -0600 |
| Cc: | Kevan Rehm <kfr@xxxxxxx>, Alex Elder <aelder@xxxxxxx> |
| In-reply-to: | <1320957318-16269-1-git-send-email-aelder@xxxxxxx> |
| In-reply-to: | <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@xxxxxxx> |
| References: | <1320957318-16269-1-git-send-email-aelder@xxxxxxx> |
| References: | <3ed89446f6dc1231ec1de712f242522052952b7e.1320955675.git.aelder@xxxxxxx> |
From: Kevan Rehm <kfr@xxxxxxx>
In phase 6, in mk_root_dir(), xfs_repair initializes the mount
point's m_rootip pointer without accounting for that reference.
This field never really used or needed in repair otherwise, and the
assigned pointer doesn't really represent a real reference to an
inode that needs to be cached. So just kill off this assignment.
Signed-off-by: Alex Elder <aelder@xxxxxxx>
---
repair/phase6.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/repair/phase6.c b/repair/phase6.c
index 1c82cb1..81d7fe6 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -797,8 +797,6 @@ mk_root_dir(xfs_mount_t *mp)
ip->i_df.if_bytes = ip->i_df.if_real_bytes = 0;
ip->i_df.if_u1.if_extents = NULL;
- mp->m_rootip = ip;
-
/*
* initialize the directory
*/
--
1.7.6.4
|
| Previous by Date: | [PATCH 8/8] xfsprogs: xfs_db: add new "resvsp" command, Alex Elder |
|---|---|
| Next by Date: | [PATCH 4/8] xfsprogs: mkfs.xfs: let libxfs_umount() do its thing, Alex Elder |
| Previous by Thread: | Re: [PATCH 8/8] xfsprogs: xfs_db: add new "resvsp" command, Dave Chinner |
| Next by Thread: | Re: [PATCH 3/8] xfsprogs: xfs_repair: don't set the root inode pointer, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |