Re: [PATCH 18/19] mkfs: unit conversions are case insensitive

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 4/7/16 5:50 AM, Jan Tulak wrote:
> On Wed, Apr 6, 2016 at 11:10 PM, Eric Sandeen <sandeen@xxxxxxxxxxx 
> <mailto:sandeen@xxxxxxxxxxx>>wrote:
> 
>     On 3/24/16 6:15 AM, jtulak@xxxxxxxxxx <mailto:jtulak@xxxxxxxxxx> wrote:
>     > From: Jan Tulak <jtulak@xxxxxxxxxx <mailto:jtulak@xxxxxxxxxx>>
>     >
>     > Solves the question "Should I use 10g or 10G?"
> 
>     Might be nicer to do it like the cvtnum in libxcmd:
> 
>             c = tolower(*sp);
>             switch (c) {
>             case 'b':
>                     return i * blocksize;
>     ...
> 
> âYeah, changed.
> â
>  
> 
> 
>     (hm, why do we have 3 copies of cvtnum?)
> 
> 
> âWhere? â
>  â
> 
> â$ pwd
> â/some/path/xfsprogs-dev
> 
> $ grep -r "cvtnum(size_t" . |grep -v "^Binary"
> â./include/input.h:extern long long cvtnum(size_t blocksize, size_t 
> sectorsize, char *s);
> ./io/init.h:extern void init_cvtnum(size_t *blocksize, size_t *sectsize);

  File                  Line
0 estimate/xfs_estimate.c   29 cvtnum(char *s)
1 libxcmd/input.c          147 cvtnum(
2 mkfs/xfs_mkfs.c         3618 cvtnum(

-Eric