| To: | xfs@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 2/4] xfs: don't pass value into attr ->put_listent |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Fri, 11 Mar 2016 16:11:42 -0600 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <56E3425E.40509@xxxxxxxxxx> |
| References: | <56E3425E.40509@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
The value is not used; only names and value lengths are
returned. Remove the argument.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
fs/xfs/xfs_attr.h | 2 +-
fs/xfs/xfs_attr_list.c | 18 ++++++------------
fs/xfs/xfs_xattr.c | 3 +--
3 files changed, 8 insertions(+), 15 deletions(-)
diff --git a/fs/xfs/xfs_attr.h b/fs/xfs/xfs_attr.h
index 2343312..dab4f41 100644
--- a/fs/xfs/xfs_attr.h
+++ b/fs/xfs/xfs_attr.h
@@ -114,7 +114,7 @@ typedef struct attrlist_cursor_kern {
/* Return 0 on success, or -errno; other state communicated via *context */
typedef int (*put_listent_func_t)(struct xfs_attr_list_context *, int,
- unsigned char *, int, int, unsigned char *);
+ unsigned char *, int, int);
typedef struct xfs_attr_list_context {
struct xfs_inode *dp; /* inode */
diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
index d5ab59f..1d36d78 100644
--- a/fs/xfs/xfs_attr_list.c
+++ b/fs/xfs/xfs_attr_list.c
@@ -106,8 +106,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context)
sfe->flags,
sfe->nameval,
(int)sfe->namelen,
- (int)sfe->valuelen,
- &sfe->nameval[sfe->namelen]);
+ (int)sfe->valuelen);
if (error)
return error;
/*
@@ -198,8 +197,7 @@ xfs_attr_shortform_list(xfs_attr_list_context_t *context)
sbp->flags,
sbp->name,
sbp->namelen,
- sbp->valuelen,
- &sbp->name[sbp->namelen]);
+ sbp->valuelen);
if (error)
return error;
if (context->seen_enough)
@@ -428,8 +426,7 @@ xfs_attr3_leaf_list_int(
entry->flags,
name_loc->nameval,
(int)name_loc->namelen,
- be16_to_cpu(name_loc->valuelen),
-
&name_loc->nameval[name_loc->namelen]);
+
be16_to_cpu(name_loc->valuelen));
if (retval)
return retval;
} else {
@@ -458,16 +455,14 @@ xfs_attr3_leaf_list_int(
entry->flags,
name_rmt->name,
(int)name_rmt->namelen,
- valuelen,
- args.value);
+ valuelen);
kmem_free(args.value);
} else {
retval = context->put_listent(context,
entry->flags,
name_rmt->name,
(int)name_rmt->namelen,
- valuelen,
- NULL);
+ valuelen);
}
if (retval)
return retval;
@@ -548,8 +543,7 @@ xfs_attr_put_listent(
int flags,
unsigned char *name,
int namelen,
- int valuelen,
- unsigned char *value)
+ int valuelen)
{
struct attrlist *alist = (struct attrlist *)context->alist;
attrlist_ent_t *aep;
diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
index f220129..7fdcf33 100644
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -166,8 +166,7 @@ xfs_xattr_put_listent(
int flags,
unsigned char *name,
int namelen,
- int valuelen,
- unsigned char *value)
+ int valuelen)
{
char *prefix;
int prefix_len;
--
1.7.1
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 1/4] xfs: only return -errno or success from attr ->put_listent, Eric Sandeen |
|---|---|
| Next by Date: | [PATCH 3/4] xfs: remove put_value from attr ->put_listent context, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 1/4] xfs: only return -errno or success from attr ->put_listent, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/4] xfs: don't pass value into attr ->put_listent, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |