| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs: remove impossible condition |
| From: | Luis de Bethencourt <luisbg@xxxxxxxxxxxxxxx> |
| Date: | Tue, 01 Mar 2016 13:23:33 +0000 |
| Cc: | linux-kernel@xxxxxxxxxxxxxxx, cmaiolino@xxxxxxxxxx, darrick.wong@xxxxxxxxxx, namjae.jeon@xxxxxxxxxxx, bfoster@xxxxxxxxxx, sandeen@xxxxxxxxxxx, xfs@xxxxxxxxxxx, billodo@xxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20160301120814.GA5217@xxxxxxxxxxxxx> |
| References: | <1456404237-18169-1-git-send-email-luisbg@xxxxxxxxxxxxxxx> <20160301120814.GA5217@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 |
On 01/03/16 12:08, Christoph Hellwig wrote: > On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote: >> bp_release is set to 0 just before the breakpoint of the for loop before >> the conditional check (in line 458). The other breakpoint is a goto that >> skips the dead code. > > Yes, this looks correct: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > The whole code around this is rather grotty and could use some more > work, though.. > Thanks for the review Christoph! If you have some specific things in mind that I could fix in the code around this, I am happy to add it to my ToDo list. Or I can continue reading it and let you know of anything I see, so you can confirm before I try to fix it. Regards, Luis |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 3/3] xfs: borrow indirect blocks from freed extent when available, Brian Foster |
|---|---|
| Next by Date: | Re: generic/320 triggers "list_add attempted on force-poisoned entry" warning on XFS, Dan Williams |
| Previous by Thread: | Re: [PATCH] xfs: remove impossible condition, Christoph Hellwig |
| Next by Thread: | Re: [PATCH] xfs: remove impossible condition, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |