xfs
[Top] [All Lists]

Pass mp to kmem_alloc and friends?

To: xfs@xxxxxxxxxxx
Subject: Pass mp to kmem_alloc and friends?
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 20 Jan 2016 11:59:09 -0600
Delivered-to: xfs@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.1
I had a request for the kmem_alloc deadlock warning to print the
filesystem involved.

Any objections to passing mp into kmem_alloc() and friends whenever
it's reasonably available from the caller?

It'd be a big mechanical change, don't want to embark on that unless
it seems acceptable & useful.

I think we generally know the root causes of the most common deadlock
warnings, but it's a warm fuzzy to give as much info as possible.

Heck, I almost wonder if passing a descriptive string in, for at
least the problematic cases we know about, i.e. "extent map realloc"
so we'd get something like:

XFS (sdb1): myprocess(123) possible memory allocation deadlock size 12345 
during extent map realloc in kmem_alloc (mode:0x250)

I dunno ... too much? :)

-Eric

<Prev in Thread] Current Thread [Next in Thread>