| To: | xfs@xxxxxxxxxxx, Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH] XFS: Use a signed return type for suffix_kstrtoint() |
| From: | SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> |
| Date: | Sun, 20 Dec 2015 08:00:29 +0100 |
| Cc: | LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Julia Lawall <julia.lawall@xxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 |
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 20 Dec 2015 07:56:36 +0100
The return type "unsigned long" was used by the suffix_kstrtoint()
function even though it will eventually return a negative error code.
Improve this implementation detail by using the type "int" instead.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
fs/xfs/xfs_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 436b6ef..59c9b7b 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -137,7 +137,7 @@ static const match_table_t tokens = {
};
-STATIC unsigned long
+STATIC int
suffix_kstrtoint(char *s, unsigned int base, int *res)
{
int last, shift_left_factor = 0, _res;
--
2.6.3
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v5 4/7] dax: add support for fsync/sync, Dan Williams |
|---|---|
| Next by Date: | Integer truncation in fs/xfs/libxfs/xfs_da_btree.c, Kristian |
| Previous by Thread: | RE: WE CAN SUPPLY CHEAPESTttt SHIP COSTttt DOOR TO DOOR BY AIR IF YOU HAVE GOODS IN CHINA, frank@xxxxxxxxxxxxxxxx |
| Next by Thread: | Re: [PATCH] XFS: Use a signed return type for suffix_kstrtoint(), Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |