xfs
[Top] [All Lists]

Re: [PATCH xfsprogs] mdrestore: do not do dynamic linking of libtool lib

To: <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH xfsprogs] mdrestore: do not do dynamic linking of libtool libraries
From: Vicente Olivert Riera <Vincent.Riera@xxxxxxxxxx>
Date: Mon, 30 Nov 2015 13:25:35 +0000
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <1448449838-47261-1-git-send-email-Vincent.Riera@xxxxxxxxxx>
References: <1448449838-47261-1-git-send-email-Vincent.Riera@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
ping

On 25/11/15 11:10, Vicente Olivert Riera wrote:
> As explained in commit ece49daeff1a3cad765e106d678c608925c9d768, use
> -static-libtool-libs instead of -static to allow fallback to the dynamic
> linking for libuuid only. Otherwise the build will fail like this:
> 
> ld: attempted static link of dynamic object `/usr/lib/libuuid.so'
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@xxxxxxxxxx>
> ---
>  mdrestore/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mdrestore/Makefile b/mdrestore/Makefile
> index 5171306..1b34a0e 100644
> --- a/mdrestore/Makefile
> +++ b/mdrestore/Makefile
> @@ -10,7 +10,7 @@ CFILES = xfs_mdrestore.c
>  
>  LLDLIBS = $(LIBXFS) $(LIBRT) $(LIBPTHREAD) $(LIBUUID)
>  LTDEPENDENCIES = $(LIBXFS)
> -LLDFLAGS = -static
> +LLDFLAGS = -static-libtool-libs
>  
>  default: depend $(LTCOMMAND)
>  
> 

<Prev in Thread] Current Thread [Next in Thread>