Re: [PATCH] xfs_metadump: obfuscate remote symlinks on CRC filesystems

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 6/21/15 4:14 AM, Christoph Hellwig wrote:
> On Fri, Jun 19, 2015 at 03:30:32PM -0500, Eric Sandeen wrote:
>> On CRC filesystems, the symlink block starts with a header,
>> which contains magic, "XLSM"
>>
>> The code happens to "work" today w/o corrupting anything,
>> because it seems "XSLM" as a string, decides it's too short
>> to obfuscate, and leaves it alone.
>>
>> But the real symlink target is untouched.  Fix that by moving
>> the pointer to the string we want to obfuscate by the size
>> of the header, and shorten the length to obfuscate accordingly.
> 
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> Any chance to get a test for this into xfstests?

I have a larger metadump testcase brewing, it'd cover this too.

Thanks,
-Eric