Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing

xfs

Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jan Tulak <jtulak@xxxxxxxxxx>
Subject:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file
From:	Eric Sandeen <sandeen@xxxxxxxxxx>
Date:	Fri, 19 Jun 2015 10:17:10 -0500
Cc:	xfs-oss <xfs@xxxxxxxxxxx>
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<20150619150904.GB22842@xxxxxxxxxxxxx>
References:	<55820229.1010701@xxxxxxxxxx> <14667996.16447259.1434625419793.JavaMail.zimbra@xxxxxxxxxx> <20150619150904.GB22842@xxxxxxxxxxxxx>

On 6/19/15 10:09 AM, Christoph Hellwig wrote:
> On Thu, Jun 18, 2015 at 07:03:39AM -0400, Jan Tulak wrote:
>> This changes get_topology only for ENABLE_BLKID branch of #ifdef. Is that 
>> intentional, i.e. we don't expect anyone not using ENABLE_BLKID? Because 
>> otherwise, if mkfs is compiled without ENABLE_BLKID, then all we get is:
> 
> I'm in favor of killing the !ENABLE_BLKID entirely.  The proper
> support in blkid has been around long enough to require it.
> 

though we also claim to nominally support building on osx, irix, etc, which 
doesn't have that library, right?

-Eric

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Jan Tulak Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Jan Tulak Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen <= Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen PATCH V2] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Eric Sandeen

Previous by Date:	Re: [PATCH 1/2] xfs: don't truncate attribute extents if no extents exist, Christoph Hellwig
Next by Date:	Re: [PATCH] xfs_repair: automatically enable -f (file) mode when needed, Eric Sandeen
Previous by Thread:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig
Next by Thread:	Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]