| To: | Theodore Ts'o <tytso@xxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/4] vfs: add support for a lazytime mount option |
| From: | Boaz Harrosh <openosd@xxxxxxxxx> |
| Date: | Tue, 25 Nov 2014 17:32:11 +0200 |
| Cc: | linux-fsdevel@xxxxxxxxxxxxxxx, Ext4 Developers List <linux-ext4@xxxxxxxxxxxxxxx>, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=OsTzyJGkVo+c/yUys39aSi7ch9tG2xutxOfDcdkuByg=; b=xGpzxBXd5Eb5llUktB79vV6WvXnrfiMvftl0B8j9S6vUuPGkqSLXY45ZNxi/EhThNz TpuGM5UxIrOsOUexsdpNFTrJW7dmTuRFErVbtlHeU8SZpsCuM2wSusS+PtRTexNX8eWt OGoI3fXnFitprPsxvjCEYQdAUCUS3+3q19bHLFkIzBJXJ0aVu+/q8/nDluJBZ502ZGpf GhBjRVkwDjQKPGHzd8xAaBSgOz6VCMDS23k97EtQ6XKyZFF2+MFY454/GS0xdy5nF9t/ JNXnOCjlPwEqSiNqVo/BH0FP8+JmrhxzlnDckydtdwRU4Tl6//0MGo0BtNY+mKs3tFsV Nohg== |
| In-reply-to: | <20141125043335.GF31339@xxxxxxxxx> |
| References: | <1416599964-21892-1-git-send-email-tytso@xxxxxxx> <1416599964-21892-3-git-send-email-tytso@xxxxxxx> <20141125015239.GD27262@dastard> <20141125043335.GF31339@xxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 11/25/2014 06:33 AM, Theodore Ts'o wrote: <> > > I was concerned about putting them on the dirty inode list because it > would be extra inodes for the writeback threads would have to skip > over and ignore (since they would not be dirty in the inde or data > pages sense). > > Another solution would be to use a separate linked list for dirtytime > inodes, but that means adding some extra fields to the inode > structure, which some might view as bloat. You could use the same list-head for both lists. If the inode is on the dirty-inode-list then no need to add it to the list-for-dirtytime, it will be written soon anyway. else you add it to the list-for-dirtytime. If you (real)dirty an inode then you first remove it from the list-for-dirtytime first, and then add it to the dirty-inode-list. So at each given time it is only on one list <> Cheers Boaz |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH-v3 3/6] vfs: don't let the dirty time inodes get more than a day stale, Rasmus Villemoes |
|---|---|
| Next by Date: | Re: [PATCH 1/4] fs: split update_time() into update_time() and write_time(), David Sterba |
| Previous by Thread: | Re: [PATCH 2/4] vfs: add support for a lazytime mount option, Theodore Ts'o |
| Next by Thread: | Re: [PATCH 2/4] vfs: add support for a lazytime mount option, Jan Kara |
| Indexes: | [Date] [Thread] [Top] [All Lists] |