| To: | Brian Foster <bfoster@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfs_io: add sync and syncfs commands |
| From: | Eric Sandeen <sandeen@xxxxxxxxxx> |
| Date: | Mon, 27 Oct 2014 10:56:41 -0500 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20141027114327.GD39598@xxxxxxxxxxxxxxx> |
| References: | <544A9511.70500@xxxxxxxxxx> <20141027114327.GD39598@xxxxxxxxxxxxxxx> |
On 10/27/14 6:43 AM, Brian Foster wrote:
> On Fri, Oct 24, 2014 at 01:06:09PM -0500, Eric Sandeen wrote:
...
>> +void
>> +sync_init(void)
>> +{
>> + sync_cmd.name = "sync";
>> + sync_cmd.cfunc = sync_f;
>> + sync_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>
> Not a big deal given that we have sync(1), but CMD_NOFILE_OK..?
>
> The rest looks good to me.
>
> Brian
Ah, good eye, thanks. Will send V2.
-Eric
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfsprogs: enable sparse checking, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] xfsprogs: enable sparse checking, Eric Sandeen |
| Previous by Thread: | Re: [PATCH] xfs_io: add sync and syncfs commands, Brian Foster |
| Next by Thread: | [PATCH V2] xfs_io: add sync and syncfs commands, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |