| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH V3] xfs_io: add mremap command |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Sat, 13 Sep 2014 15:12:07 -0500 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20140913194559.GA28479@xxxxxxxxxxxxx> |
| References: | <54111610.4080604@xxxxxxxxxx> <54132553.9090202@xxxxxxxxxxx> <20140913194559.GA28479@xxxxxxxxxxxxx> |
On 9/13/14 2:45 PM, Christoph Hellwig wrote: > On Fri, Sep 12, 2014 at 11:54:43AM -0500, Eric Sandeen wrote: >> This adds a simple mremap command to xfs_io. >> >> It does not take a start address; it uses the existing >> start address, so the sized passed will be the new total >> size of the mapping. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Looks good to me, but I'd feel much more comfortable about merging it > if we had an xfstests test case that actually exercises it. > I did it for a crazy mremap failure we saw, I'll probably end up writing a testcase for that which uses it. I could easily enough write a test to exercise this directly too, I'll look into it. Thanks, -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: symlink loop for /lib64/libhandle.so, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [RFD] xfs_fsr: Doubts related to xfs_fsr code, Eric Sandeen |
| Previous by Thread: | Re: [PATCH V3] xfs_io: add mremap command, Christoph Hellwig |
| Next by Thread: | [RFC] Unicode/UTF-8 support for XFS, Ben Myers |
| Indexes: | [Date] [Thread] [Top] [All Lists] |