xfs
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH V2] xfs: combine xfs_seek_hole & xfs_seek_data

from [Jeff Liu] [Permanent Link][Original]
To: Eric Sandeen <sandeen@xxxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH V2] xfs: combine xfs_seek_hole & xfs_seek_data
From: Jeff Liu <jeff.liu@xxxxxxxxxx>
Date: Fri, 22 Aug 2014 19:50:31 +0800
Delivered-to: xfs@xxxxxxxxxxx
In-reply-to: <53F64723.4070001@xxxxxxxxxxx>
References: <53F55765.6030205@xxxxxxxxxx> <53F64723.4070001@xxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 
On 08/22/2014 03:23 AM, Eric Sandeen wrote:
> xfs_seek_hole & xfs_seek_data are remarkably similar;
> so much so that they can be combined, saving a fair
> bit of semi-complex code duplication.
> 
> The following patch passes generic/285 and generic/286,
> which specifically test seek behavior.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good to me. 

Reviewed-by: Jie Liu <jeff.liu@xxxxxxxxxx>


Cheers,
-Jeff
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] xfs: lseek: the "whence" argument is called "whence", Brian Foster
Next by Date:  Re: [PATCH] xfs: lseek: the "whence" argument is called "whence", Jeff Liu
Previous by Thread:  Re: [PATCH V2] xfs: combine xfs_seek_hole & xfs_seek_data, Brian Foster
Next by Thread:  [PATCH] xfs: deduplicate xlog_do_recovery_pass(), Eric Sandeen
Indexes:  [Date] [Thread] [Top] [All Lists]