| To: | Jeff Liu <jeff.liu@xxxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH RFC] xfs: combine xfs_seek_hole & xfs_seek_data |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Thu, 21 Aug 2014 09:20:26 -0500 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <53F5E822.9010507@xxxxxxxxxx> |
| References: | <53F55765.6030205@xxxxxxxxxx> <53F5E822.9010507@xxxxxxxxxx> |
On 8/21/14, 7:37 AM, Jeff Liu wrote: > With the current refactoring, the code logic still looks easy to understand, > so I personally vote this change. > > BTW, originally I have also tried to implement SEEK_HOLE/DATA in one routine > in my 1st round of patch which was shown as following. However, I failed to > make the code looks readable and works correctly at that time. > > http://oss.sgi.com/archives/xfs/2011-11/msg00364.html > http://oss.sgi.com/archives/xfs/2011-11/msg00395.html > > > Cheers, > -Jeff Ah, I had forgotten about that! Good idea! ;) -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/6] xfs: mmap write/read leaves bad state on pages, Anton Altaparmakov |
|---|---|
| Next by Date: | Re: [PATCH RFC] xfs: combine xfs_seek_hole & xfs_seek_data, Brian Foster |
| Previous by Thread: | Re: [PATCH RFC] xfs: combine xfs_seek_hole & xfs_seek_data, Jeff Liu |
| Next by Thread: | Re: [PATCH RFC] xfs: combine xfs_seek_hole & xfs_seek_data, Brian Foster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |