| To: | "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH v3 01/10] xfs: remove redundant stat assignment in xfs_bulkstat_one_int |
| From: | Jeff Liu <jeff.liu@xxxxxxxxxx> |
| Date: | Tue, 03 Jun 2014 17:17:50 +0800 |
| Delivered-to: | xfs@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
From: Jie Liu <jeff.liu@xxxxxxxxxx>
Remove the redundant BULKSTAT_RV_NOTHING assignment in case of call
xfs_iget() failed at xfs_bulkstat_one_int().
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
---
fs/xfs/xfs_itable.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/xfs/xfs_itable.c b/fs/xfs/xfs_itable.c
index cb64f22..2e7b397 100644
--- a/fs/xfs/xfs_itable.c
+++ b/fs/xfs/xfs_itable.c
@@ -76,10 +76,8 @@ xfs_bulkstat_one_int(
error = xfs_iget(mp, NULL, ino,
(XFS_IGET_DONTCACHE | XFS_IGET_UNTRUSTED),
XFS_ILOCK_SHARED, &ip);
- if (error) {
- *stat = BULKSTAT_RV_NOTHING;
+ if (error)
goto out_free;
- }
ASSERT(ip != NULL);
ASSERT(ip->i_imap.im_blkno != 0);
@@ -136,7 +134,6 @@ xfs_bulkstat_one_int(
IRELE(ip);
error = formatter(buffer, ubsize, ubused, buf);
-
if (!error)
*stat = BULKSTAT_RV_DIDONE;
--
1.8.3.2
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC 11/32] xfs: convert to struct inode_time, Dave Chinner |
|---|---|
| Next by Date: | [PATCH v3 00/10] xfs_ioc_bulkstat code refactoring and consolidation, Jeff Liu |
| Previous by Thread: | Re: [PATCH 17/16] xfs: remove redundant geometry information from xfs_da_state, Brian Foster |
| Next by Thread: | [PATCH v3 00/10] xfs_ioc_bulkstat code refactoring and consolidation, Jeff Liu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |