Re: [PATCH v3] xfstests: Btrfs: add test for large metadata blocks

[Koen De Wit <koen.de.wit@xxxxxxxxxx>]

On 02/10/2014 11:04 PM, Dave Chinner wrote:

On Mon, Feb 10, 2014 at 10:39:22PM +0100, Koen De Wit wrote:

+
+_test_illegal_leafsize() {
+        _scratch_mkfs -l $1 >>$seqres.full 2>&1
+        [ $? -ne 0 ] || _fail "'$1' is an illegal value for the" \
+                "leafsize option, mkfs should have failed."
+}

You just re-implemented run_check....

I believe I didn't :

run_check()
{
        echo "# $@" >> $seqres.full 2>&1
        "$@" >> $seqres.full 2>&1 || _fail "failed: '$@'"
}

run_check() takes an arbitrary command and executes it, _test_illegal_leafsize() takes a leafsize as parameter and tries mkfs.btrfs with that leafsize. run_check() makes the test fail if the return code is not zero, _test_illegal_leafsize() does the opposite.

Thanks,
Koen.