Re: nfs vs xfstests 193

[Stanislav Kholmanskikh <stanislav.kholmanskikh@xxxxxxxxxx>]

On 12/07/2013 12:47 AM, J. Bruce Fields wrote:
> On Fri, Dec 06, 2013 at 03:44:04PM -0500, bfields wrote:
> > On Fri, Dec 06, 2013 at 10:08:58AM -0800, Christoph Hellwig wrote:
> > > On Fri, Dec 06, 2013 at 05:20:34PM +0400, Stanislav Kholmanskikh wrote:
> > > > Just to make the behaviour more consistent between NFS and other
> > > > "local" file systems as It was done by
> > > > commit 
> > > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=0953e620de0538cbd081f1b45126f6098112a598
> > > Seems like we got others in line with XFS behavior.
> > But, not having tested the behavior, it looks like fs/open.c has a
> > simlar !S_ISDIR() check.  Where's that behavior implemented?
> >
> > > I'd prefer to have NFS follow this as well.
> > Huh.  Sachin, do you remember if there was any other motivation behind
> > that patch?
> Never mind, I see, the complaint is about the case where the id's don't
> change, not about the directory case.  So Sachin's
> 0953e620de0538cbd081f1b45126f6098112a598 doesn't actually have anything
> to do with this.
>
> I'm fine with removing the id comparisons and changing the nfsd behavior
> to match local filesystems.
Great.

I will try to produce a patch for this.

> --b.
>
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs