Re: [PATCH 0/5] xfs: more patches for 3.13

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

On 11/13/13, 7:16 PM, Dave Chinner wrote:

> That's client side, not server side, so that's the NFS client inode
> it is locking, not the server side XFS inode.

Ah, geez, you're right. (x3)

<snip>

> Server side, where i_version is pulled out of an XFS inode:
> 
> $ git grep i_version fs/nfsd
> fs/nfsd/nfs3xdr.c:      fhp->fh_post_change = 
> fhp->fh_dentry->d_inode->i_version;
> fs/nfsd/nfs4xdr.c:              write64(p, inode->i_version);
> fs/nfsd/nfsfh.h:                fhp->fh_pre_change = inode->i_version;
> $
> 
> the nfsfh.h hit is in fill_pre_wcc(), which appears to be called
> under i_mutex but not i_lock. The xdr encoding functions don't
> appear to be holding i_lock, and may be holding i_mutex, but I
> haven't looked that far.

I'm still not sure how 

> Cheers,
> 
> Dave.
>