| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/4 V2] xfs: remove newlines from strings passed to __xfs_printk |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Sat, 12 Oct 2013 16:07:38 -0500 |
| Cc: | Eric Sandeen <sandeen@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx> |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <5258ACE9.6000401@xxxxxxxxxxx> |
| References: | <52584C8A.1060808@xxxxxxxxxx> <52584D04.3020907@xxxxxxxxxxx> <5258ACE9.6000401@xxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 10/11/13 20:59, Eric Sandeen wrote: __xfs_printk adds its own "\n". Having it in the original string leads to unintentional blank lines from these messages. Most format strings have no newline, but a few do, leading to i.e.: [ 7347.119911] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119911] [ 7347.119919] XFS (sdb2): Access to block zero in inode 132 start_block: 0 start_off: 0 blkcnt: 0 extent-state: 0 lastx: 1a05 [ 7347.119919] Fix them all. Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx> --- Thanks for the updated patch. It looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | GRATUITES : 8 fiches utiles internet, Internet Gartuit |
|---|---|
| Next by Date: | Re: [PATCH 2/4] xfs: reject completely bogus remount options, Mark Tinguely |
| Previous by Thread: | [PATCH 1/4 V2] xfs: remove newlines from strings passed to __xfs_printk, Eric Sandeen |
| Next by Thread: | [PATCH 2/4] xfs: reject completely bogus remount options, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |