| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 03/32] xfs: fix some minor sparse warnings |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Tue, 08 Oct 2013 17:56:00 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1380510944-8571-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1380510944-8571-1-git-send-email-david@xxxxxxxxxxxxx> <1380510944-8571-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 9/29/13 10:15 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> A couple of simple locking annotations and 0 vs NULL warnings.
> Nothing that changes any code behaviour, just removes build noise.
The patch is fine as it is, but it doesn't reflect the commit log.
Is part of it missing?
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> libxfs/xfs_bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libxfs/xfs_bmap.c b/libxfs/xfs_bmap.c
> index 2d480cc..7336abf 100644
> --- a/libxfs/xfs_bmap.c
> +++ b/libxfs/xfs_bmap.c
> @@ -4415,7 +4415,7 @@ xfs_bmapi_write(
> {
> struct xfs_mount *mp = ip->i_mount;
> struct xfs_ifork *ifp;
> - struct xfs_bmalloca bma = { 0 }; /* args for xfs_bmap_alloc */
> + struct xfs_bmalloca bma = { NULL }; /* args for xfs_bmap_alloc */
> xfs_fileoff_t end; /* end of mapped file region */
> int eof; /* after the end of extents */
> int error; /* error return */
>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 01/32] xfsprogs: fix automatic dependency generation, Eric Sandeen |
| Previous by Thread: | Re: [PATCH 02/32] libxfs: fix missing filetype updates to xfs_dir2.c, Eric Sandeen |
| Next by Thread: | Re: [PATCH 03/32] xfs: fix some minor sparse warnings, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |