| To: | Mark Tinguely <tinguely@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 0/2] misc kernel leak patches |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Wed, 02 Oct 2013 15:54:04 -0500 |
| Cc: | xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20131002125110.745269864@xxxxxxx> |
| References: | <20131002125110.745269864@xxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 |
On 10/2/13 7:51 AM, Mark Tinguely wrote: > Here are a couple patches to free leaked memory. > > First patch is v2 of a Coverity found leak in xfs_dir2_node_removename(). > > Second patch arose from an eariler leak found by Coverity. In looking > at that patch, Eric noted that it appeared that the transaction's > item list is also leaked if recovery fails. I tested this patch by forcing > errors into the recovery code to verify that the items are now being released. > > I will send patches for xfsprogs equivalent. Good plan w.r.t. kernel first, progs 2nd, I think. Makes it less likely to accidentally send a free(); or similar upstream. :) -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 1/2] xfs: fix memory leak in xfs_dir2_node_removename, Dave Chinner |
|---|---|
| Next by Date: | [PATCH] xfs: add the inode directory type support to XFS_IOC_FSGEOM, Mark Tinguely |
| Previous by Thread: | Re: [PATCH 1/2] xfs: fix memory leak in xfs_dir2_node_removename, Mark Tinguely |
| Next by Thread: | Re: [PATCH 13/16] xfs: vectorise encoding/decoding directory headers, Michael L. Semon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |