Re: [PATCH 2/5] xfs: lock the AIL before removing the buffer item

xfs

Re: [PATCH 2/5] xfs: lock the AIL before removing the buffer item

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 2/5] xfs: lock the AIL before removing the buffer item
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Tue, 24 Sep 2013 11:12:37 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1380002476-18839-3-git-send-email-david@xxxxxxxxxxxxx>
References:	<1380002476-18839-1-git-send-email-david@xxxxxxxxxxxxx> <1380002476-18839-3-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 09/24/13 01:01, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

Regression introduced by commit 46f9d2e ("xfs: aborted buf items can
be in the AIL") which fails to lock the AIL before removing the
item. Spinlock debugging throws a warning about this.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., (continued) Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Mark Tinguely Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Ben Myers Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Dave Chinner Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Ben Myers Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Dave Chinner [PATCH 3/5] xfs: asserting lock not held during freeing not valid, Dave Chinner Re: [PATCH 3/5] xfs: asserting lock not held during freeing not valid, Mark Tinguely [PATCH 4/5] xfs: fix XFS_IOC_FREE_EOFBLOCKS definition, Dave Chinner Re: [PATCH 4/5] xfs: fix XFS_IOC_FREE_EOFBLOCKS definition, Mark Tinguely [PATCH 2/5] xfs: lock the AIL before removing the buffer item, Dave Chinner Re: [PATCH 2/5] xfs: lock the AIL before removing the buffer item, Mark Tinguely <= [PATCH 5/5] xfs: log recovery lsn ordering needs uuid check, Dave Chinner Re: [PATCH 5/5] xfs: log recovery lsn ordering needs uuid check, Ben Myers Re: [PATCH 0/5] xfs: fixes for 3.12-rc3, Ben Myers

Previous by Date:	Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error., Ben Myers
Next by Date:	Re: [PATCH 4/5] xfs: fix XFS_IOC_FREE_EOFBLOCKS definition, Mark Tinguely
Previous by Thread:	[PATCH 2/5] xfs: lock the AIL before removing the buffer item, Dave Chinner
Next by Thread:	[PATCH 5/5] xfs: log recovery lsn ordering needs uuid check, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]