Re: [PATCH 1/5] xfs: don't try to mark uncached buffers stale on error.

[Mark Tinguely <tinguely@xxxxxxx>]

On 09/24/13 01:01, Dave Chinner wrote:
> From: Dave Chinner<dchinner@xxxxxxxxxx>
>
> fsstress failed during a shutdown with the following assert:
>
> XFS: Assertion failed: xfs_buf_islocked(bp), file: fs/xfs/xfs_buf.c, line: 143
> .....
>   xfs_buf_stale+0x3f/0xf0
>   xfs_bioerror_relse+0x2d/0x90
>   xfsbdstrat+0x51/0xa0
>   xfs_zero_remaining_bytes+0x1d1/0x2d0
>   xfs_free_file_space+0x5d0/0x600
>   xfs_change_file_space+0x251/0x3a0
>   xfs_ioc_space+0xcc/0x130
> .....
>
> xfs_zero_remaining_bytes() works with uncached buffers, and hence if
> we are preventing IO due to a shutdown, we should not be marking it
> stale as that is only for cached buffers. Instead, just mark it with
> an error and make sure it gets to the caller.
>
> Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
> ---
Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>