| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfsprogs: fix unint var in repair phase6 |
| From: | Mark Tinguely <tinguely@xxxxxxx> |
| Date: | Thu, 01 Aug 2013 09:50:38 -0500 |
| Cc: | "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx> |
| Delivered-to: | linux-xfs@xxxxxxxxxxx |
| In-reply-to: | <51F9B626.4010707@xxxxxxxxxx> |
| References: | <51F9B626.4010707@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0 |
On 07/31/13 20:13, Eric Sandeen wrote: 2 calls to libxfs_bmapi_write exist in repair's phase6 where "first" is uninitialized, but is accessed in that function. Normally we call xfs_bmap_init() first to initialize both the free list and the first block, but in these cases, the free list var is sent as NULL. So in these 2 cases, explicitly initialize the "first" variable to NULLFSBLOCK as xfs_bmap_init() does elsewhere. Coverity caught this. Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx> --- Looks good. Reviewed-by: Mark Tinguely <tinguely@xxxxxxx> |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfsprogs: fix buffer leak in xlog_print_find_oldest, Mark Tinguely |
|---|---|
| Next by Date: | Re: [PATCH] xfsprogs: fix agcnts leak in xfs_repair's scan_ags, Mark Tinguely |
| Previous by Thread: | Re: [PATCH] xfsprogs: fix buffer leak in xlog_print_find_oldest, Mark Tinguely |
| Next by Thread: | Re: [PATCH] xfsprogs: fix agcnts leak in xfs_repair's scan_ags, Mark Tinguely |
| Indexes: | [Date] [Thread] [Top] [All Lists] |