Re: [PATCH] xfs:free bp in xlog_find

xfs

Re: [PATCH] xfs:free bp in xlog_find_tail() error path

To:	Eric Sandeen <sandeen@xxxxxxxxxx>
Subject:	Re: [PATCH] xfs:free bp in xlog_find_tail() error path
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Thu, 01 Aug 2013 09:11:39 -0500
Cc:	"'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>
Delivered-to:	linux-xfs@xxxxxxxxxxx
In-reply-to:	<51F9BAFB.9000808@xxxxxxxxxx>
References:	<51F9BAFB.9000808@xxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/31/13 20:33, Eric Sandeen wrote:

xlog_find_tail() currently leaks a bp on one error path.

There is no error target, so manually free the bp before
returning the error.

Found by Coverity.

Signed-off-by: Eric Sandeen<sandeen@xxxxxxxxxx>
---

p.s. this can be merged to userspace as well.


Looks good.

Reviewed-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] xfs:free bp in xlog_find_tail() error path, Mark Tinguely <= Re: [PATCH] xfs:free bp in xlog_find_tail() error path, Ben Myers

Previous by Date:	Re: [PATCH] xfs: free bp in xlog_find_zeroed() error path, Mark Tinguely
Next by Date:	Re: [PATCH] xfs: avoid double-free in xfs_attr_node_addname, Mark Tinguely
Previous by Thread:	Re: [PATCH] xfs: free bp in xlog_find_zeroed() error path, Mark Tinguely
Next by Thread:	Re: [PATCH] xfs:free bp in xlog_find_tail() error path, Ben Myers
Indexes:	[Date] [Thread] [Top] [All Lists]