Re: [PATCH 47/49] xfs: split the CIL lock

xfs

Re: [PATCH 47/49] xfs: split the CIL lock

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 47/49] xfs: split the CIL lock
From:	Mark Tinguely <tinguely@xxxxxxx>
Date:	Mon, 29 Jul 2013 17:24:14 -0500
Cc:	xfs@xxxxxxxxxxx
Delivered-to:	xfs@xxxxxxxxxxx
In-reply-to:	<1374215120-7271-48-git-send-email-david@xxxxxxxxxxxxx>
References:	<1374215120-7271-1-git-send-email-david@xxxxxxxxxxxxx> <1374215120-7271-48-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20120122 Thunderbird/9.0

On 07/19/13 01:25, Dave Chinner wrote:

From: Dave Chinner<dchinner@xxxxxxxxxx>

The xc_cil_lock is used for two purposes - to protect the CIL
itself, and to protect the push/commit state and lists. These are
two logically separate structures and operations, so can have their
own locks. This means that pushing on the CIL and the commit wait
ordering won't contend for a lock with other transactions that are
completing concurrently. As the CIL insertion is the hottest path
throught eh CIL, this is a big win.

Signed-off-by: Dave Chinner<dchinner@xxxxxxxxxx>
---


read semaphore/xc_cil_lock (original lock) protects cil entries
write semaphore/xc_push_lock (new lock) protects the cil push

Looks good.

Review-by: Mark Tinguely <tinguely@xxxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, (continued) Re: [PATCH 36/49] xfs: Introduce tr_fsyncts to m_reservation, Mark Tinguely [PATCH 34/49] xfs: make struct xfs_perag kernel only, Dave Chinner Re: [PATCH 34/49] xfs: make struct xfs_perag kernel only, Mark Tinguely [PATCH 07/49] xfs: split out on-disk transaction definitions, Dave Chinner Re: [PATCH 07/49] xfs: split out on-disk transaction definitions, Brian Foster [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Mark Tinguely Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Dave Chinner Re: [PATCH 14/49] xfs: introduce xfs_inode_buf.c for inode buffer operations, Brian Foster [PATCH 47/49] xfs: split the CIL lock, Dave Chinner Re: [PATCH 47/49] xfs: split the CIL lock, Mark Tinguely <= [PATCH 02/49] xfs: split out inode log item format definition, Dave Chinner Re: [PATCH 02/49] xfs: split out inode log item format definition, Brian Foster Re: [PATCH 02/49] xfs: split out inode log item format definition, Mark Tinguely [PATCH 05/49] xfs: separate dquot on disk format definitions out of xfs_quota.h, Dave Chinner Re: [PATCH 05/49] xfs: separate dquot on disk format definitions out of xfs_quota.h, Brian Foster [PATCH 11/49] xfs: split out transaction reservation code, Dave Chinner Re: [PATCH 11/49] xfs: split out transaction reservation code, Brian Foster [PATCH 12/49] xfs: move inode fork definitions to a new header file, Dave Chinner Re: [PATCH 12/49] xfs: move inode fork definitions to a new header file, Mark Tinguely Re: [PATCH 00/49] current patch queue for 3.12, Michael L. Semon

Previous by Date:	Vážení E-mail užívateľa;, webmail update
Next by Date:	кадастровый план, оформление земли
Previous by Thread:	[PATCH 47/49] xfs: split the CIL lock, Dave Chinner
Next by Thread:	[PATCH 02/49] xfs: split out inode log item format definition, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]