| To: | Eric Sandeen <sandeen@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] xfstests: generic/315: add one more sync and more output |
| From: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
| Date: | Mon, 29 Jul 2013 12:38:25 -0500 |
| Cc: | Josef Bacik <jbacik@xxxxxxxxxxxx>, jeff.liu@xxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx |
| Delivered-to: | xfs@xxxxxxxxxxx |
| In-reply-to: | <51F6A6DA.3080102@xxxxxxxxxx> |
| References: | <1375118463-29654-1-git-send-email-jbacik@xxxxxxxxxxxx> <51F6A6DA.3080102@xxxxxxxxxx> |
| User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
On 7/29/13 12:31 PM, Eric Sandeen wrote: > Honest question: does one more sync make this deterministic, or is it a > best-effort, um, hack? I'm not quite sure why even 1 sync is needed. :( I'm not sure what bug this is trying to test; if you need 2 syncs for global space stats to accurately reflect the fact that you chopped off the end of a block, maybe that's ... still a bug? Or if it's just the big-hammer question of "does the truncated space *ever* get freed?" then maybe umount/remount/check would tell you that more definitively. -Eric |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] xfstests: generic/315: add one more sync and more output, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH 45/49] xfs: avoid CIL allocation during insert, Mark Tinguely |
| Previous by Thread: | Re: [PATCH] xfstests: generic/315: add one more sync and more output, Eric Sandeen |
| Next by Thread: | Re: [PATCH] xfstests: generic/315: add one more sync and more output, Josef Bacik |
| Indexes: | [Date] [Thread] [Top] [All Lists] |